Revert "Revert "Fix get_nested_resource_ptr to accept both str and bytes inputs""#1698
Open
Revert "Revert "Fix get_nested_resource_ptr to accept both str and bytes inputs""#1698
Conversation
…tes inpu…" This reverts commit 2d85f3e.
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Collaborator
Author
|
/ok to test |
|
Collaborator
Author
|
/ok to test |
leofang
reviewed
Feb 27, 2026
Collaborator
Author
|
/ok to test |
Contributor
|
@rparolin Looks like there are conflicts. |
Contributor
|
Nit (non-blocking): in get_nested_resource_ptr() for the char path, would isinstance(obj_i, (str, bytes)) be preferable to exact type(...) is ... checks? That is a bit more permissive for subclasses while keeping behavior the same for normal inputs. |
cpcloud
approved these changes
Mar 4, 2026
Contributor
cpcloud
left a comment
cpcloud
left a comment
There was a problem hiding this comment.
Looks good to me. Left one non-blocking nit in a separate comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1697